Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github_team data source #14614

Merged
merged 3 commits into from
May 22, 2017
Merged

Add github_team data source #14614

merged 3 commits into from
May 22, 2017

Conversation

raphink
Copy link
Contributor

@raphink raphink commented May 18, 2017

This PR adds a data source for Github teams.

@stack72
Copy link
Contributor

stack72 commented May 18, 2017

Hi @raphink

This is looking good - unfortunately, before merging, would you be able to write some documentation for it?

Thanks

Paul

@stack72 stack72 added enhancement new-data-source provider/github waiting-response An issue/pull request is waiting for a response from the community labels May 18, 2017
@raphink
Copy link
Contributor Author

raphink commented May 18, 2017

@stack72 sorry, I thought I had. I will certainly do that.

@raphink
Copy link
Contributor Author

raphink commented May 19, 2017

@stack72 added doc

@stack72
Copy link
Contributor

stack72 commented May 20, 2017

Hi @raphink

Thanks for adding the docs - these look great. On last check, the test is failing:

% make testacc TEST=./builtin/providers/github TESTARGS='-run=TestAccGithubTeamDataSource_noMatchReturnsError'                               ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/21 00:45:36 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/github -v -run=TestAccGithubTeamDataSource_noMatchReturnsError -timeout 120m
=== RUN   TestAccGithubTeamDataSource_noMatchReturnsError
--- FAIL: TestAccGithubTeamDataSource_noMatchReturnsError (1.25s)
	testing.go:274: Step 0, expected error:

		Error refreshing: 1 error(s) occurred:

		* data.github_team.test: 1 error(s) occurred:

		* data.github_team.test: data.github_team.test: Could not find team with slug: non-existing

		To match:

		Not Found


FAIL
exit status 1
FAIL	github.com/hashicorp/terraform/builtin/providers/github	1.260s
make: *** [testacc] Error 1

@raphink
Copy link
Contributor Author

raphink commented May 21, 2017

Ah, my bad @stack72. It should be fine now.

@stack72
Copy link
Contributor

stack72 commented May 22, 2017

LGTM now sir :)

% make testacc TEST=./builtin/providers/github TESTARGS='-run=TestAccGithubTeamDataSource'                                           
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/22 15:27:19 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/github -v -run=TestAccGithubTeamDataSource -timeout 120m
=== RUN   TestAccGithubTeamDataSource_noMatchReturnsError
--- PASS: TestAccGithubTeamDataSource_noMatchReturnsError (0.73s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/github	0.746s

@stack72 stack72 merged commit e7bfdea into hashicorp:master May 22, 2017
@raphink
Copy link
Contributor Author

raphink commented May 22, 2017

Great thanks!

@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement new-data-source provider/github waiting-response An issue/pull request is waiting for a response from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants