Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add ability to 'terraform import' aws_kms_alias resources #14679

Merged
merged 1 commit into from
May 19, 2017
Merged

provider/aws: Add ability to 'terraform import' aws_kms_alias resources #14679

merged 1 commit into from
May 19, 2017

Conversation

ewbankkit
Copy link
Contributor

Enable terraform import of KMS aliases using the name attribute.
Acceptance tests:

make testacc TEST=./builtin/providers/aws/ TESTARGS='-run=TestAccAWSKmsAlias_import'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/19 14:32:25 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws/ -v -run=TestAccAWSKmsAlias_import -timeout 120m
=== RUN   TestAccAWSKmsAlias_importBasic
--- PASS: TestAccAWSKmsAlias_importBasic (44.72s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	44.735s

Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@grubernaut grubernaut merged commit 51620cf into hashicorp:master May 19, 2017
@ewbankkit ewbankkit deleted the import-aws_kms_key_alias branch May 19, 2017 19:37
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants