provider/github Check for potentially nil response from GitHub API client #14683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub API client methods usually return 3 values - object, resp, err.
If a non-
nil
err is returned, object will benil
but resp may or may not benil
.In a few places in the GitHub provider there were assumptions that when
err != nil
,resp != nil
and I hit this when I had an invalid GitHub token at one point and got a nil-pointer dereference panic.Acceptance tests: