Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/docker network alias #14710

Merged
merged 10 commits into from
May 22, 2017
Merged

Conversation

jwayong
Copy link
Contributor

@jwayong jwayong commented May 21, 2017

This is addressing #10452 - basically an implementation where configuration can specify network_alias set of strings in a user-defined network. This is similar to --network-alias command from docker run.

For example you can do something like:

resource "docker_container" "web01" {
  image = "${docker_image.nginx.latest}"
  name  = "${var.environment}_web01"
  networks = ["${docker_network.private_network.name}"]
  network_alias = ["web01", "anotherweb01"]
}

And this will create Aliases of web01 and anotherweb01

@jwayong jwayong changed the title Provider Docker network alias provider/docker network alias May 21, 2017
Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@grubernaut grubernaut merged commit cf8568f into hashicorp:master May 22, 2017
@jwayong jwayong deleted the docker-network-alias branch May 22, 2017 14:33
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants