Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/openstack: Add openstack_dns_zone_v2 resource #14721

Merged
merged 3 commits into from
May 22, 2017

Conversation

jtopjian
Copy link
Contributor

This commit adds the openstack_dns_zone_v2 resource to manage a DNS zone in the OpenStack DNS service.

For #14603

@jtopjian
Copy link
Contributor Author

==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/22 01:48:36 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/openstack -v -run=TestAccDNSV2Zone -timeout 120m
=== RUN   TestAccDNSV2Zone_importBasic
--- PASS: TestAccDNSV2Zone_importBasic (35.67s)
=== RUN   TestAccDNSV2Zone_basic
--- PASS: TestAccDNSV2Zone_basic (61.08s)
=== RUN   TestAccDNSV2Zone_readTTL
--- PASS: TestAccDNSV2Zone_readTTL (34.94s)
=== RUN   TestAccDNSV2Zone_timeout
--- PASS: TestAccDNSV2Zone_timeout (35.09s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/openstack      166.814s

@stack72 This is all good on my side. Since I have commits in this PR, can you do a quick code review?

@stack72
Copy link
Contributor

stack72 commented May 22, 2017

LGTM sir :) Merge at will :)

@jtopjian jtopjian merged commit a8bf3d8 into hashicorp:master May 22, 2017
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants