Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/openstack: Add support for updating Subnet Allocation Pools #14782

Merged
merged 2 commits into from
May 24, 2017

Conversation

jtopjian
Copy link
Contributor

This commit adds the ability to update a subnet's allocation pool.

Fixes #10942

@jtopjian
Copy link
Contributor Author

==> Checking that code complies with gofmt requirements...                                      
go generate $(go list ./... | grep -v /terraform/vendor/)                                       
2017/05/23 23:42:46 Generated command/internal_plugin_list.go                                   
TF_ACC=1 go test ./builtin/providers/openstack -v -run=TestAccNetworkingV2Subnet -timeout 120m  
=== RUN   TestAccNetworkingV2Subnet_importBasic                                                 
--- PASS: TestAccNetworkingV2Subnet_importBasic (45.99s)                                        
=== RUN   TestAccNetworkingV2Subnet_basic                                                       
--- PASS: TestAccNetworkingV2Subnet_basic (54.13s)                                              
=== RUN   TestAccNetworkingV2Subnet_enableDHCP                                                  
--- PASS: TestAccNetworkingV2Subnet_enableDHCP (45.78s)                                         
=== RUN   TestAccNetworkingV2Subnet_disableDHCP                                                 
--- PASS: TestAccNetworkingV2Subnet_disableDHCP (43.41s)                                        
=== RUN   TestAccNetworkingV2Subnet_noGateway                                                   
--- PASS: TestAccNetworkingV2Subnet_noGateway (45.25s)                                          
=== RUN   TestAccNetworkingV2Subnet_impliedGateway                                              
--- PASS: TestAccNetworkingV2Subnet_impliedGateway (46.12s)                                     
=== RUN   TestAccNetworkingV2Subnet_timeout                                                     
--- PASS: TestAccNetworkingV2Subnet_timeout (45.69s)                                            
PASS                                                                                            
ok      github.com/hashicorp/terraform/builtin/providers/openstack      326.409s                

@stack72
Copy link
Contributor

stack72 commented May 24, 2017

LGTM :) Thanks for this!

@stack72 stack72 merged commit da8f71d into hashicorp:master May 24, 2017
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Openstack provider doesn't update subnet allocation_pools
2 participants