Add support for changing TTL on DigitalOcean domain records.

[andrewsomething]

The DO API was extended to support configuring the TTL value for individual domain records. See:

https://developers.digitalocean.com/documentation/changelog/api-v2/configurable-ttl-for-domain-records/

This PR adds support for that as well as updating the vendorized copy of godo. That required a few changes:

• The introduction of Context usage.
• The deprecation of tag renaming. See:
  https://developers.digitalocean.com/documentation/changelog/api-v2/deprecating-update-tag/

Fixes: #12631

[stack72]

Hi @andrewsomething

Thanks for this - unfortunately, this doesn't pass the tests:

=== RUN   TestAccDigitalOceanDroplet_WithID
--- FAIL: TestAccDigitalOceanDroplet_WithID (0.38s)
	testing.go:280: Step 0 error: Error applying: 1 error(s) occurred:

		* digitalocean_droplet.foobar: 1 error(s) occurred:

		* digitalocean_droplet.foobar: Error creating droplet: POST https://api.digitalocean.com/v2/droplets: 422 You specified an invalid image for Droplet creation.
=== RUN   TestAccDigitalOceanDroplet_withSSH
--- FAIL: TestAccDigitalOceanDroplet_withSSH (16.40s)
	testing.go:280: Step 0 error: Error applying: 1 error(s) occurred:

		* digitalocean_droplet.foobar: 1 error(s) occurred:

		* digitalocean_droplet.foobar: Error waiting for droplet () to become ready: strconv.Atoi: parsing "": invalid syntax
=== RUN   TestAccDigitalOceanDroplet_Update
--- FAIL: TestAccDigitalOceanDroplet_Update (14.41s)
	testing.go:280: Step 0 error: Error applying: 1 error(s) occurred:

		* digitalocean_droplet.foobar: 1 error(s) occurred:

		* digitalocean_droplet.foobar: Error waiting for droplet () to become ready: strconv.Atoi: parsing "": invalid syntax
=== RUN   TestAccDigitalOceanDroplet_ResizeWithOutDisk
--- FAIL: TestAccDigitalOceanDroplet_ResizeWithOutDisk (14.52s)
	testing.go:280: Step 0 error: Error applying: 1 error(s) occurred:

		* digitalocean_droplet.foobar: 1 error(s) occurred:

		* digitalocean_droplet.foobar: Error waiting for droplet () to become ready: strconv.Atoi: parsing "": invalid syntax
=== RUN   TestAccDigitalOceanDroplet_ResizeOnlyDisk
--- FAIL: TestAccDigitalOceanDroplet_ResizeOnlyDisk (14.33s)
	testing.go:280: Step 0 error: Error applying: 1 error(s) occurred:

		* digitalocean_droplet.foobar: 1 error(s) occurred:

		* digitalocean_droplet.foobar: Error waiting for droplet () to become ready: strconv.Atoi: parsing "": invalid syntax
=== RUN   TestAccDigitalOceanDroplet_UpdateUserData
--- FAIL: TestAccDigitalOceanDroplet_UpdateUserData (14.30s)
	testing.go:280: Step 0 error: Error applying: 1 error(s) occurred:

		* digitalocean_droplet.foobar: 1 error(s) occurred:

		* digitalocean_droplet.foobar: Error waiting for droplet () to become ready: strconv.Atoi: parsing "": invalid syntax
=== RUN   TestAccDigitalOceanDroplet_UpdateTags
--- FAIL: TestAccDigitalOceanDroplet_UpdateTags (14.34s)
	testing.go:280: Step 0 error: Error applying: 1 error(s) occurred:

		* digitalocean_droplet.foobar: 1 error(s) occurred:

		* digitalocean_droplet.foobar: Error waiting for droplet () to become ready: strconv.Atoi: parsing "": invalid syntax
=== RUN   TestAccDigitalOceanDroplet_PrivateNetworkingIpv6
--- PASS: TestAccDigitalOceanDroplet_PrivateNetworkingIpv6 (58.70s)
=== RUN   TestAccDigitalOceanFloatingIP_Region
--- PASS: TestAccDigitalOceanFloatingIP_Region (4.62s)
=== RUN   TestAccDigitalOceanFloatingIP_Droplet
--- FAIL: TestAccDigitalOceanFloatingIP_Droplet (42.39s)
	testing.go:280: Step 0 error: Error applying: 1 error(s) occurred:

		* digitalocean_droplet.foobar: 1 error(s) occurred:

		* digitalocean_droplet.foobar: Error waiting for droplet () to become ready: strconv.Atoi: parsing "": invalid syntax
=== RUN   TestAccDigitalOceanLoadbalancer_Basic
--- FAIL: TestAccDigitalOceanLoadbalancer_Basic (14.91s)
	testing.go:280: Step 0 error: Error applying: 1 error(s) occurred:

		* digitalocean_droplet.foobar: 1 error(s) occurred:

		* digitalocean_droplet.foobar: Error waiting for droplet () to become ready: strconv.Atoi: parsing "": invalid syntax
=== RUN   TestAccDigitalOceanLoadbalancer_Updated
--- FAIL: TestAccDigitalOceanLoadbalancer_Updated (14.24s)
	testing.go:280: Step 0 error: Error applying: 1 error(s) occurred:

		* digitalocean_droplet.foobar: 1 error(s) occurred:

		* digitalocean_droplet.foobar: Error waiting for droplet () to become ready: strconv.Atoi: parsing "": invalid syntax
=== RUN   TestAccDigitalOceanLoadbalancer_dropletTag
--- FAIL: TestAccDigitalOceanLoadbalancer_dropletTag (16.85s)
	testing.go:280: Step 0 error: Error applying: 1 error(s) occurred:

		* digitalocean_droplet.foobar: 1 error(s) occurred:

		* digitalocean_droplet.foobar: Error waiting for droplet () to become ready: strconv.Atoi: parsing "": invalid syntax

Can you take a look?

Paul

[andrewsomething]

@stack72 Looks like that is actually an error on the DO API side. The Droplet creation events are failing. So probably best to rerun when the status page is green: http://status.digitalocean.com/

[andrewsomething]

The DO status page is back to green, and I just successfully ran the acceptance tests.

[tombuildsstuff]

Hi @andrewsomething

Thanks for letting us know - apologies for the delayed response here. Would it be possible to fix the merge conflicts? Once this is done we can progress with this :)

Thanks!

[andrewsomething]

Well, it's a much smaller patch now. 😄

[stack72]

This LGTM now :) Thanks for taking care of this

[pinepain]

@andrewsomething thanks a lot for this change!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.