fixed tests. should fail

[opteemister]

No description provided.

[opteemister]

That's strange. 1st commit should fail tests, but passed. 2nd commit should pass tests, but failed.
1st - because there are no changes of required field were made. You can see it from changes in 2nd commit
2nd - That should be there because of https://github.com/zorkian/go-datadog-api/blob/master/monitors.go#L47
I found autogenerated file vendor/gopkg.in/zorkian/go-datadog-api.v2/datadog-accessors.go which should fit to that change, but I don't know how to check if it applies latest changes.

Can someone help me with this? Or advice how to improve this?

[opteemister]

@stack72 could you please review this? I hope that fix will be in the next version of terraform. Thanks

[stack72]

Hi @opteemister

Sorry for the delay here - this LGTM!

% make testacc TEST=./builtin/providers/datadog                                                                                              ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/06/05 14:45:34 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/datadog -v  -timeout 120m
=== RUN   TestDatadogDowntime_import
--- PASS: TestDatadogDowntime_import (4.22s)
=== RUN   TestDatadogMonitor_import
--- PASS: TestDatadogMonitor_import (4.76s)
=== RUN   TestDatadogUser_import
--- PASS: TestDatadogUser_import (6.38s)
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccDatadogDowntime_Basic
--- PASS: TestAccDatadogDowntime_Basic (2.82s)
=== RUN   TestAccDatadogDowntime_BasicMultiScope
--- PASS: TestAccDatadogDowntime_BasicMultiScope (2.87s)
=== RUN   TestAccDatadogDowntime_BasicNoRecurrence
--- PASS: TestAccDatadogDowntime_BasicNoRecurrence (2.64s)
=== RUN   TestAccDatadogDowntime_BasicUntilDateRecurrence
--- PASS: TestAccDatadogDowntime_BasicUntilDateRecurrence (3.00s)
=== RUN   TestAccDatadogDowntime_BasicUntilOccurrencesRecurrence
--- PASS: TestAccDatadogDowntime_BasicUntilOccurrencesRecurrence (2.85s)
=== RUN   TestAccDatadogDowntime_WeekDayRecurring
--- PASS: TestAccDatadogDowntime_WeekDayRecurring (3.04s)
=== RUN   TestAccDatadogDowntime_Updated
--- PASS: TestAccDatadogDowntime_Updated (5.69s)
=== RUN   TestAccDatadogDowntime_TrimWhitespace
--- PASS: TestAccDatadogDowntime_TrimWhitespace (2.87s)
=== RUN   TestResourceDatadogDowntimeRecurrenceTypeValidation
--- PASS: TestResourceDatadogDowntimeRecurrenceTypeValidation (0.00s)
=== RUN   TestResourceDatadogDowntimeRecurrenceWeekDaysValidation
--- PASS: TestResourceDatadogDowntimeRecurrenceWeekDaysValidation (0.00s)
=== RUN   TestAccDatadogMonitor_Basic
--- PASS: TestAccDatadogMonitor_Basic (3.42s)
=== RUN   TestAccDatadogMonitor_BasicNoTreshold
--- PASS: TestAccDatadogMonitor_BasicNoTreshold (3.22s)
=== RUN   TestAccDatadogMonitor_Updated
--- PASS: TestAccDatadogMonitor_Updated (8.02s)
=== RUN   TestAccDatadogMonitor_TrimWhitespace
--- PASS: TestAccDatadogMonitor_TrimWhitespace (3.22s)
=== RUN   TestAccDatadogMonitor_Basic_float_int
--- PASS: TestAccDatadogMonitor_Basic_float_int (6.65s)
=== RUN   TestAccDatadogTimeboard_update
--- PASS: TestAccDatadogTimeboard_update (10.01s)
=== RUN   TestValidateAggregatorMethod
--- PASS: TestValidateAggregatorMethod (0.00s)
=== RUN   TestAccDatadogUser_Updated
--- PASS: TestAccDatadogUser_Updated (7.17s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/datadog	82.874s

Paul

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.