Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Avoid crash when EgressOnly IGW disappears #14929

Merged
merged 1 commit into from
May 30, 2017

Conversation

radeksimko
Copy link
Member

This is to avoid the following intermittent test failure:

=== RUN   TestAccAWSRoute_ipv6Support

------- Stderr: -------
panic: runtime error: index out of range

goroutine 499 [running]:
github.com/hashicorp/terraform/builtin/providers/aws.EIGWStateRefreshFunc.func1(0xc42000e0c0, 0xc4204b4680, 0x16, 0xc4204b4a00, 0x24b5c40, 0xc4203c5c70)
    /opt/teamcity-agent/work/aed1168611c3040/src/github.com/hashicorp/terraform/builtin/providers/aws/resource_aws_egress_only_internet_gateway.go:84 +0x1a2
github.com/hashicorp/terraform/builtin/providers/aws.resourceAwsEgressOnlyInternetGatewayCreate.func1(0x2)
    /opt/teamcity-agent/work/aed1168611c3040/src/github.com/hashicorp/terraform/builtin/providers/aws/resource_aws_egress_only_internet_gateway.go:45 +0x6e
github.com/hashicorp/terraform/helper/resource.Retry.func1(0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
    /opt/teamcity-agent/work/aed1168611c3040/src/github.com/hashicorp/terraform/helper/resource/wait.go:22 +0x78
github.com/hashicorp/terraform/helper/resource.(*StateChangeConf).WaitForState.func1(0xc4206c6720, 0xc4207821c0, 0xc4206e0880, 0xc4206c6780, 0xc420366718, 0xc420366710)
    /opt/teamcity-agent/work/aed1168611c3040/src/github.com/hashicorp/terraform/helper/resource/state.go:103 +0x1c8
created by github.com/hashicorp/terraform/helper/resource.(*StateChangeConf).WaitForState
    /opt/teamcity-agent/work/aed1168611c3040/src/github.com/hashicorp/terraform/helper/resource/state.go:195 +0x249

Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radeksimko radeksimko merged commit b802897 into master May 30, 2017
@radeksimko radeksimko deleted the b-aws-egress-igw-crash-fix branch May 30, 2017 19:40
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants