Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/alicloud: Fix access_key NOT FOUND bug and nat_gateway diff bug #15050

Merged
merged 1 commit into from
Jun 4, 2017

Conversation

xiaozhu36
Copy link
Contributor

This PR fix the following bugs:

  1. When setting access_key to "", running 'terraform apply' will raise ACCESS KEY NOT FOUND error. And the PR fix the bug by using ENV ALICLOUD_ACCESS_KEY and ALICLOUD_SECRET_KEY.
  2. When creating nat gateway, if set "zone" is nil, diff resource will appear error. Now, the PR set "zone" Compute is true.

The running result of nat gateway testcase as follows:

TF_ACC=1 go test ./alicloud -v -run=TestAccAlicloudNatGateway -timeout 120m
=== RUN TestAccAlicloudNatGateway_basic
--- PASS: TestAccAlicloudNatGateway_basic (76.65s)
=== RUN TestAccAlicloudNatGateway_spec
--- PASS: TestAccAlicloudNatGateway_spec (69.36s)
PASS
ok github.com/alibaba/terraform-provider/alicloud 146.017s

@stack72
Copy link
Contributor

stack72 commented Jun 4, 2017

Hi @xiaozhu36

This LGTM! thanks for this :)

Paul

@stack72 stack72 merged commit c70c54b into hashicorp:master Jun 4, 2017
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants