Allow resizing of Google Cloud persistent disks

[bashtoni]

make testacc TEST=./builtin/providers/google TESTARGS='-run=TestAccComputeDisk_updateSize'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/06/05 11:31:09 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccComputeDisk_updateSize -timeout 120m
=== RUN   TestAccComputeDisk_updateSize
--- PASS: TestAccComputeDisk_updateSize (28.37s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/google	28.377s

[stack72]

Hi @bashtoni

Left a few small things inline - please let me know your thoughts

Paul

[stack72]

This can be removed completely :)

[stack72]

Does the machine have to be stopped? Do we have to wait for a specific status before we know that this has worked as expected?

[bashtoni]

Resizing is an on-line operation. The API docs don't specify the possible states of a disk, and I've never been able to observe another state than 'Ready'.

[bashtoni]

@stack72 Thanks for reviewing Paul. I removed the unnecessary ForceNew: false.

[stack72]

LGTM! thanks for making the change and the explanation :)

P.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.