Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform: when pruning destroy, only match exact nodes, or exact counts #1527

Merged
merged 2 commits into from
Apr 14, 2015

Conversation

mitchellh
Copy link
Contributor

This fixes an issue where the Terraform prune destroy transform was invalidly keeping the destroy node around for things that didn't need it. Example: if you had a resource "foo" and "foo-bar" and "foo-bar" needed to be kept around, it'd also keep "foo" because of the way prefix checking was before.

if k == prefix+".0" {
continue
}

if v.Primary != nil {
println("FUCK: " + prefix + " ; " + k)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debugging

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the lowercase version here, I think it's less "yelling" 👅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doot de dooooooooooooo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to see here, just @mitchellh's Fast Understanding, Confusion Killing ™️ debugging system.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do this on the plane a lot and one time a lady looked over and was somewhat confused as to why "FUCK" was just scrolling matrix-style down my terminal.

Anyways, NSFW, will be more careful.

@phinze
Copy link
Contributor

phinze commented Apr 14, 2015

Ah.... b-sad-destroy indeed. Yeah I squinted at the prefix matching the first time around - shoulda asked. Welp it's all good now! 👍

mitchellh added a commit that referenced this pull request Apr 14, 2015
terraform: when pruning destroy, only match exact nodes, or exact counts
@mitchellh mitchellh merged commit c8fb1c7 into master Apr 14, 2015
@mitchellh mitchellh deleted the b-sad-destroy branch April 14, 2015 20:21
@ghost
Copy link

ghost commented May 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants