-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
terraform: when pruning destroy, only match exact nodes, or exact counts #1527
Conversation
if k == prefix+".0" { | ||
continue | ||
} | ||
|
||
if v.Primary != nil { | ||
println("FUCK: " + prefix + " ; " + k) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debugging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the lowercase version here, I think it's less "yelling" 👅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doot de dooooooooooooo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to see here, just @mitchellh's Fast Understanding, Confusion Killing ™️ debugging system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do this on the plane a lot and one time a lady looked over and was somewhat confused as to why "FUCK" was just scrolling matrix-style down my terminal.
Anyways, NSFW, will be more careful.
Ah.... b-sad-destroy indeed. Yeah I squinted at the prefix matching the first time around - shoulda asked. Welp it's all good now! 👍 |
terraform: when pruning destroy, only match exact nodes, or exact counts
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This fixes an issue where the Terraform prune destroy transform was invalidly keeping the destroy node around for things that didn't need it. Example: if you had a resource "foo" and "foo-bar" and "foo-bar" needed to be kept around, it'd also keep "foo" because of the way prefix checking was before.