Floating IP support for LBaaS Virtual IP #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggiamarchi
force-pushed
the
openstack/lb_vip_floatingip
branch
from
6711c9c
to
d855047
Compare
|
Someone to review this one ? Actually, without this feature the LBaaS is not really usable in most of the situations as long as the virtual IP will generally not be on a public network. /cc @phinze @mitchellh |
|
LGTM. Any way you can get an acceptance test case in @ggiamarchi? |
mitchellh
added a commit
that referenced
this pull request
Apr 22, 2015
Floating IP support for LBaaS Virtual IP
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is not possible to assign a floating IP to a LB virtual IP. This PR adds a
floating_ipattribute to theopenstack_lb_vip_v1resource.