config: Make 'id' a reserved field name

[radeksimko]

This is to prevent mistakes like #9366 and generally to improve dev experience.

I could add a test, but both slices are already tested and it seems unnecessary to test just a one new item in existing slice.

[jbardin]

This LGTM as long as we're sure that it's not breaking any provider mistakingly using id. Because this is handled in the config loader, I don't think it would be caught by the ACC tests themselves.

[radeksimko]

it's not breaking any provider mistakingly using id.

if there's a resource with such field then that field is useless in the schema anyways AFAIK.

I don't think it would be caught by the ACC tests themselves

it will emerge in tests once we start bumping vendored hashicorp/terraform in all providers, because each provider test calls InternalValidate() where this will be reported. Also, we're intentionally bypassing this check for Deprecated & Removed fields, so that things can disappear gracefully - but frankly in case of id (or most other reserved fields) there's really no need to deprecate it, because they get removed before the CRUD even gets chance to read them.

[jbardin]

thanks for confirming @radeksimko ;)
👍

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.