don't allow leading slashes in s3 remote state key #15738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apparentlymart
approved these changes
Aug 7, 2017
backend/remote-state/s3/backend.go
Outdated
| // s3 will strip leading slashes from an object, so while this will | ||
| // technically be accepted by s3, it will break our workspace hierarchy. | ||
| if strings.HasPrefix(v.(string), "/") { | ||
| return nil, []error{fmt.Errorf("key cannot contain a leading '/'")} |
There was a problem hiding this comment.
This is totally a nit, but "contain a leading slash" reads funny to me since I guess I don't think of a prefix as being "contained".
Suggest instead: "key must not start with '/'"
S3 accepts objects with a leading slash and strips them off. This works fine except in our workspace hierarchy, which then can no longer find suffixes matching the full key name.
jbardin
force-pushed
the
jbardin/s3-key-validation
branch
from
2dfc34b
to
4c7cd54
Compare
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3 accepts objects with a leading slash and strips them off. This works
fine except in our workspace hierarchy, which then can no longer find
suffixes matching the full key name.
Fixes #15645