Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Fix issue when creating ELB with no tags #1580

Merged
merged 1 commit into from
Apr 17, 2015

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Apr 17, 2015

The ELB API does not like when you send it a slice of *elb.Tag with length greater than 0, but no actual elements in it. Basically.

@phinze
Copy link
Contributor

phinze commented Apr 17, 2015

with length greater than 0

But that was only the third arg, capacity, that was being set.

@phinze
Copy link
Contributor

phinze commented Apr 17, 2015

But hey, if this fixes it, then I'm all 👍

@catsby
Copy link
Contributor Author

catsby commented Apr 17, 2015

I misspoke above about the details, but the conclusion was right. It's length was zero, and AWS rejected that. We needed to send nil (or just omit the attribute, same affect)

catsby added a commit that referenced this pull request Apr 17, 2015
provider/aws: Fix issue when creating ELB with no tags
@catsby catsby merged commit d9e8c11 into master Apr 17, 2015
@justincampbell justincampbell deleted the b-aws-elb-fix-tags branch May 6, 2015 13:48
@ghost
Copy link

ghost commented May 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants