Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't re-do a ASG on a grace healthcheck grace period change #1682

Merged
merged 2 commits into from
Apr 29, 2015
Merged

Don't re-do a ASG on a grace healthcheck grace period change #1682

merged 2 commits into from
Apr 29, 2015

Conversation

mzupan
Copy link
Contributor

@mzupan mzupan commented Apr 26, 2015

Right now if the health_check_grace_period is changed it will re-create the ASG. You can do it in the web UI without a reload. This PR allows that to happen.

aws_autoscaling_group.rabbit: Modifying...
  health_check_grace_period: "200" => "3000"
aws_autoscaling_group.rabbit: Modifications complete

Next run

aws_autoscaling_group.rabbit: Refreshing state... (ID: WEB rabbit autoscale)

If I missed something let me know and I'll update the PR.

This PR references #1679

Tested

```
aws_autoscaling_group.rabbit: Modifying...
  health_check_grace_period: "200" => "3000"
aws_autoscaling_group.rabbit: Modifications complete
```
@mitchellh
Copy link
Contributor

Looks perfect to me. An acceptance test would be wonderful but for a change this simple I can understand not having it. Thanks!

mitchellh added a commit that referenced this pull request Apr 29, 2015
provider/aws: Don't re-do a ASG on a grace healthcheck grace period change
@mitchellh mitchellh merged commit b45cd28 into hashicorp:master Apr 29, 2015
@mzupan
Copy link
Contributor Author

mzupan commented Apr 29, 2015

@mitchellh going forward is there a PR with an example acceptance test you can reference if you have one off hand

@mitchellh
Copy link
Contributor

Take a look at the recently closed provider/aws ones and also just the source itself :)

@ghost
Copy link

ghost commented May 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants