Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates the chef provisioner to allow specifying a channel #17355

Merged
merged 2 commits into from
Mar 20, 2018
Merged

Updates the chef provisioner to allow specifying a channel #17355

merged 2 commits into from
Mar 20, 2018

Conversation

scotthain
Copy link

This also updates the omnitruck url to the current url.

Signed-off-by: Scott Hain shain@chef.io

@scotthain
Updates the chef provisioner to allow specifying a channel
2c64e31 
This also updates the omnitruck url to the current url.

Signed-off-by: Scott Hain <shain@chef.io>
schisamo
schisamo suggested changes Feb 14, 2018
View reviewed changes
builtin/provisioners/chef/linux_provisioner_test.go Outdated
@@ -120,7 +120,26 @@ func TestResourceProvider_linuxInstallChefClient(t *testing.T) {

Commands: map[string]bool{
"curl -LO https://www.chef.io/chef/install.sh": true,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update this URL to be https://omnitruck.chef.io/install.sh (along with all other spots www.chef.io is being used in test and no-test files).

schisamo
schisamo suggested changes Feb 14, 2018
View reviewed changes
builtin/provisioners/chef/linux_provisioner.go Outdated
@@ -11,7 +11,7 @@ import (

const (
chmod = "find %s -maxdepth 1 -type f -exec /bin/chmod %d {} +"
installURL = "https://www.chef.io/chef/install.sh"
installURL = "https://omnitruck.chef.io/chef/install.sh"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop the chef in this URL...we just want to use https://omnitruck.chef.io/install.sh, more details at https://docs.chef.io/packages.html#omnitruck-install-script-options

@scotthain scotthain force-pushed the shain/update_chef_provisioning branch 2 times, most recently from 396cd84 to 6d8152a Compare February 15, 2018 19:50
@scotthain scotthain force-pushed the shain/update_chef_provisioning branch from 6d8152a to ec96de2 Compare February 26, 2018 23:45
@scotthain
Update omnitruck URL
7bab1e4 
Signed-off-by: Scott Hain <shain@chef.io>
@scotthain scotthain force-pushed the shain/update_chef_provisioning branch from ec96de2 to 7bab1e4 Compare February 26, 2018 23:54
@scotthain
Copy link
Author

Hey folks - any chance we could get an ETA on merging this? Thanks in advance!

@svanharmelen
Copy link
Contributor

Thanks for this one @scotthain! LGTM and it also fixes PR #17020, so here goes...

@svanharmelen svanharmelen merged commit 07aeea5 into hashicorp:master Mar 20, 2018
@svanharmelen svanharmelen mentioned this pull request Mar 20, 2018
Closed
@scotthain scotthain deleted the shain/update_chef_provisioning branch March 20, 2018 16:31
jbardin pushed a commit that referenced this pull request Mar 20, 2018
@scotthain @jbardin
Updates the chef provisioner to allow specifying a channel (#17355)
78d4aa7 
* Updates the chef provisioner to allow specifying a channel

This also updates the omnitruck url to the current url.

Signed-off-by: Scott Hain <shain@chef.io>

* Update omnitruck URL

Signed-off-by: Scott Hain <shain@chef.io>
@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schisamo schisamo schisamo approved these changes

Assignees
No one assigned
Labels
enhancement provisioner/chef
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scotthain @svanharmelen @schisamo @apparentlymart