providers/aws: S3 bucket website support

[justincampbell]

• Create/update/destroy
• index/error document
• Computed endpoint
• Multi-region support
• Docs

provider "aws" { region = "us-east-1" }

resource "aws_s3_bucket" "default" {
  bucket = "tf.justincampbel.me"
  acl = "public-read"

  website {
    index_document = "index.html"
    error_document = "error.html"
  }
}

output "dns_name" { value = "${aws_s3_bucket.default.website_endpoint}" }
// "tf.justincampbell.me.s3-website-us-east-1.amazonaws.com"

[justincampbell]

This doesn't seem to set website_endpoint to "" if you disable website support on an existing bucket. How do I trigger other resources that depend on that attribute to be updated?

[phinze]

I'd actually just add an acceptance test that includes the disable case to test this. So it'd be a test with one step that has website support and the next step that removes it.

[justincampbell]

Done in bb63f5c

[catsby]

I think a website {} block would be a better UX here. Happy to pair on this if you'd like

[catsby]

This is just a personal preference, but I prefer explicit returns when possible. I don't think that's a requirement, but I believe most of TF is consistent there.

[catsby]

Looks solid! 👍

[justincampbell]

@catsby do these look ok? http://cl.ly/image/0F03161P2o0S/Screen%20Shot%202015-05-01%20at%209.53.04%20AM.png

[catsby]

Are we OK with this PR as is, with #1769 being a separate PR?

[mitchellh]

It looks like the Read fucntion doesn't update the website index/error document. Can we get that fixed? Other than that it looks good!

[justincampbell]

@mitchellh done!

[phinze]

Alright this looks ready to 🚢 🙆‍♀️

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.