Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenStack: add functionality to attach FloatingIP to Port #1788

Merged
merged 1 commit into from
Oct 5, 2015

Conversation

JeanMertz
Copy link
Contributor

A couple of notes:

  • I didn't write any tests, because I apparently can't even break any tests. Whenever I change random test values in _test.go files, and run go test ./..., all tests still pass. As soon as I manage to get a test-workflow going, I will try my hand at the tests.
  • I tested this on my own OpenStack environment, and things work as expected.
  • The possibility to actually manage ports is introduced here: implement "openstack_networking_port_v2" resource #1789

@mitchellh
Copy link
Contributor

LGTM, same with tests here

@josephholsten
Copy link
Contributor

@mitchellh is this waiting on anything to merge?

@josephholsten
Copy link
Contributor

@phinze this seems ready to merge

@DanyC97
Copy link

DanyC97 commented Oct 3, 2015

+1

@phinze
Copy link
Contributor

phinze commented Oct 5, 2015

LGTM - thank you!

phinze added a commit that referenced this pull request Oct 5, 2015
OpenStack: add functionality to attach FloatingIP to Port
@phinze phinze merged commit 5b4bbf0 into hashicorp:master Oct 5, 2015
@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants