Bump terraform-provider-aws (1.14.1) and aws-sdk-go (1.13.28)

[elblivion]

Followed #17428 to do this.

We have need of this functionality (hashicorp/terraform-provider-aws#2883) also for remote state, hopefully this PR should be enough.

Cheers

[elblivion]

make test passes, and we've validated in local testing that the desired functionality works! 🎉

[elblivion]

Whoops, didn't notice #17896 had been opened while I was fighting with my golang dev setup. This build passes though :-D

[danbf]

need this too for the webacl regional support. @apparentlymart @bflad how would we get this merged? https://github.com/terraform-providers/terraform-provider-aws/releases is moving fast and us peeps need the support for the new things.

[elblivion]

@danbf you shouldn't need this update to be able to use the newer plugin versions - just do terraform init -upgrade and make sure you're not pinning the plugin version in your config (https://www.terraform.io/docs/configuration/providers.html#provider-versions)

The aim of this PR is to be able to use newer AWS SDK functionality in Remote State, Terraform itself uses the provider as a library in order to access S3 & DynamoDB.

That being said, we're still blocked in our specific use case (use of profiles defined in ~/.aws/config) due to this.

[twang-rs]

Also waiting eagerly to get this merged. It’s a very small PR and solves many problems. What can we do to speed this along?

[danbf]

@tombuildsstuff how do we get this or a similar plugin version update merged?

[elblivion]

Hi, we're really keen on this making it to 0.11.8 so we can better manage our multi-account environment. :-)

Anything else we can provide to speed this up?

Thanks!

[bflad]

If we release Terraform 0.11.8 then this will get in beforehand, otherwise it will be going into 0.12.0.

[elblivion]

Hi, any news on this? Where can I find out more about the release schedule/plans? Thanks!

[apparentlymart]

@bflad if this looks okay to you then feel free to merge this now, and we can include it in the next release. It doesn't seem like it includes any breaking changes, so no need to hold off to merge for the 0.12.0 release unless you know of something I don't!

I think you'd mentioned to me that there were other AWS provider changes upstream that are not covered by this PR because they came later, so if you'd rather instead merge a newer vendor update then that's fine by me too, again as long as there aren't any breaking changes in the code we'd be using from upstream then.

[bflad]

Thanks @apparentlymart! I'll double check this PR for correctness. If its good I'll merge it so the original submitter gets credit then submit a followup update. Otherwise, I'll close this one and submit a PR to supersede this with the latest updates. 😄

[bflad]

One minor feedback item probably due to the ordering of govendor commands, but otherwise LGTM. Since its minor (no material file changes to the actual dependencies) I will add a followup commit on merge to adjust the vendor.json appropriately. 🚀

As far as I can tell, the CHANGELOG updates will be under enhancements:

* backend/s3: Allow fallback to session-derived credentials (e.g. session via `AWS_PROFILE` environment variable and shared configuration)
* backend/s3: Allow usage of `AWS_EC2_METADATA_DISABLED` environment variable

[bflad]

Nitpick: These new dependencies were pulled in via git revision instead of a matching tag similar to the rest of the aws/aws-sdk-go dependencies.

diff --git a/vendor/vendor.json b/vendor/vendor.json
index f9ca8daff..90de5b930 100644
--- a/vendor/vendor.json
+++ b/vendor/vendor.json
@@ -903,8 +903,10 @@
 		{
 			"checksumSHA1": "AO97b1GChOs2geiFc//6YcpVfX8=",
 			"path": "github.com/aws/aws-sdk-go/service/lexmodelbuildingservice",
-			"revision": "f63b41ba024702aca32b063327a0852f9758d914",
-			"revisionTime": "2018-04-19T23:04:09Z"
+			"revision": "7f68df2a5baf19398d17def23a514a6e617e5937",
+			"revisionTime": "2018-04-04T18:37:54Z",
+			"version": "v1.13.28",
+			"versionExact": "v1.13.28"
 		},
 		{
 			"checksumSHA1": "jyxQ6TEdSl9/j7qC0LCkVMSXkog=",
@@ -941,8 +943,10 @@
 		{
 			"checksumSHA1": "smOJ/rypXb18/Rjryf2a85paSa4=",
 			"path": "github.com/aws/aws-sdk-go/service/organizations",
-			"revision": "f63b41ba024702aca32b063327a0852f9758d914",
-			"revisionTime": "2018-04-19T23:04:09Z"
+			"revision": "7f68df2a5baf19398d17def23a514a6e617e5937",
+			"revisionTime": "2018-04-04T18:37:54Z",
+			"version": "v1.13.28",
+			"versionExact": "v1.13.28"
 		},
 		{
 			"checksumSHA1": "vL235vodhgG61BkUxRD4B7io+zk=",

[elblivion]

Fantastic, thanks! 🎉

[RevREB]

@apparentlymart @bflad I do love that the issue i had with terraform appears to already have a patch in flight... I'm wondering when (as in # of days) till this is expected to be released? I saw that 0.12.0 but...

[apparentlymart]

There will be a new 0.11 release containing this in the very near future.

[RevREB]

oh please let it be later tonight... that would make life so much better :p

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.