Fix logging in rsadecrypt

[ashald]

rsadecrypt logs private key when cannot base64 decode input string

[apparentlymart]

Thanks for finding and fixing this, @ashald!

We had a bug on master at the time you forked to work on this it seems, which is what caused the test failures here. It's now been fixed, so it should work once we rebase it.

This set of function implementations will be phased out in the next major release, and it looks like this bug was also ported over to the replacement function implementations for the new language implementation:

terraform/lang/funcs/crypto.go

Lines 145 to 148 in 816452d

	b, err := base64.StdEncoding.DecodeString(s)
	if err != nil {
	return cty.UnknownVal(cty.String), fmt.Errorf("Failed to decode input %q: cipher text must be base64-encoded", key)
	}

...so we'll need to make sure to get that fixed on the branch before we merge it down to master.

Thanks again, Ashald!

[ashald]

Pushed rebased version.
Looks like there is nothing I can do about the new version of the function but will keep an eye on it. ;)

[apparentlymart]

Thanks for rebasing! I was actually about to do that myself while merging, but nice to see confirmation that the tests are indeed green now. 😀

[apparentlymart]

I just pushed d12a3d6 to make the same change to the new implementation, along with removing the key from two other error messages in this function. This version will be the one used in the next major release of Terraform.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.