provider/aws: Add expanded name as output to route53_record

[radeksimko]

This is a follow-up PR to #1126

With this change, the following:

${aws_route53_record.log.name}.${aws_route53_zone.primary.name}

can be shortened to this:

${aws_route53_record.log.fqdn}

and more importantly if the zone is part of another module, I don't have to pass in the domain as a string into the module where I'm creating a record.

I'm still not entirely sure about the name - fqdn, it could also be expanded_name, what do you think @catsby ?

[radeksimko]

@justincampbell What do you think of the suggested name here?

[phinze]

I, for one, like FQDN (if the value as constructed is indeed an FQDN)

[justincampbell]

fqdn sounds ok. dnsimple_record exports hostname.

The Route53 interface uses value as the host, and name as the fully-qualified name. However, it also uses name as the domain name in other places.

I would usually defer to whichever terminology the Route53 API/docs/UI uses, but I think fqdn is very clear about what it is.

[radeksimko]

Cool, I will just add this to docs then and 🚢

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.