backend/remote: add a new backend for storing state and running operations remotely #18596
Conversation
svanharmelen
changed the title
svanharmelen
changed the title
svanharmelen
force-pushed
the
svh/f-remote-backend
branch
2 times, most recently
from
29a779e
to
1a67f7f
Compare
It’s a purely cosmetic change, but I find it easier to read them like this.
By adding this method you now only have to pass a `*disco.Disco` object around in order to do discovery and use any configured credentials for the discovered hosts. Of course you can also still pass around both a `*disco.Disco` and a `auth.CredentialsSource` object if there is a need or a reason for that!
svanharmelen
force-pushed
the
svh/f-remote-backend
branch
from
1a67f7f
to
95fc0e6
Compare
apparentlymart
requested review from
a team
and removed request for
apparentlymart
backend/backend.go
Outdated
| "You can create a new workspace wth the \"workspace new\" command") | ||
|
|
||
| // ErrOperationNotSupported is returned when an unsupported operation | ||
| // is detecte by the configured backend. |
| "\n\nThe \"remote\" backend currently only supports the \"plan\" operation.\n"+ | ||
| "Please use the remote backend web UI for all other operations:\n"+ | ||
| "https://%s/app/%s/%s", b.hostname, b.organization, op.Workspace) | ||
| // return nil, backend.ErrOperationNotSupported |
There was a problem hiding this comment.
I left this one on purpose as its going to be something I want to pickup in the next iteration (as soon as this one is merged). So, for this one time, I would like to leave this line in...
| func TestRemote_planBasic(t *testing.T) { | ||
| b := testBackendDefault(t) | ||
|
|
||
| mod, modCleanup := module.TestTree(t, "./test-fixtures/plan") |
There was a problem hiding this comment.
It might be a good idea to wrap these paths in a function to set the path with the correct path separator. Not a big deal yet, but eventually we want our tests to be able to run on windows.
There was a problem hiding this comment.
I'll have a look, but I would say that deserves a PR on its own then (to update that everywhere). As now it would stand out if I do it here, while no other backends tests currently do that... Something with consistency 😉 yet I totally get your point 👍
| func TestRemote_backendDefault(t *testing.T) { | ||
| b := testBackendDefault(t) | ||
| backend.TestBackendStates(t, b) | ||
| backend.TestBackendStateLocks(t, b, b) |
There was a problem hiding this comment.
I didn't catch if it's supported, but there's also a separate TestBackendStateForceUnlock
There was a problem hiding this comment.
Ah, thanks for the pointer. I'll have a look at that Monday morning.
There was a problem hiding this comment.
Added it to the test 👍
svanharmelen
force-pushed
the
svh/f-remote-backend
branch
from
95fc0e6
to
ee11ef8
Compare
svanharmelen
force-pushed
the
svh/f-remote-backend
branch
from
ee11ef8
to
7fb2d1b
Compare
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
This new backend is called
remoteand is the second natively supported enhanced backend next to the existinglocalbackend.As its name implies, where the
localbackend stores state and runs operations locally theremotebackend stores state and runs operations remotely.The supported remote endpoints must support the full TFE V2 API, so only Terraform Enterprise and Private Terraform Enterprise are currently supported endpoints.