Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend/remote: add support for state locking #18826

Merged
merged 1 commit into from
Sep 10, 2018
Merged

backend/remote: add support for state locking #18826

merged 1 commit into from
Sep 10, 2018

Conversation

svanharmelen
Copy link
Contributor

No description provided.

@svanharmelen svanharmelen requested a review from a team September 10, 2018 13:34
jbardin
jbardin approved these changes Sep 10, 2018
View reviewed changes
Copy link
Member

@jbardin jbardin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good functionally, just some comments/questions inline that you may want to consider.

backend/remote/backend_test.go Show resolved Hide resolved
backend/remote/backend_state.go Show resolved Hide resolved
@svanharmelen svanharmelen force-pushed the f-state-locker branch 3 times, most recently from 657cf08 to aa2a777 Compare September 10, 2018 17:32
@svanharmelen
Copy link
Contributor Author

Travis is actually green, but really slow and it's probably not going to update the commit status anymore. So merging as is...

@svanharmelen svanharmelen merged commit c64d8bd into master Sep 10, 2018
@svanharmelen svanharmelen deleted the f-state-locker branch September 10, 2018 19:16
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jbardin jbardin jbardin approved these changes

Assignees
No one assigned
Labels
backend/remote enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svanharmelen @jbardin