Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial SQS support #1939

Merged
merged 3 commits into from
May 15, 2015
Merged

Initial SQS support #1939

merged 3 commits into from
May 15, 2015

Conversation

johnewart
Copy link
Contributor

Initial support for making / updating / removing SQS queues; feedback welcome.

@radeksimko
Copy link
Member

@johnewart Thanks for the contribution,
have you looked at #1888 ? It has already tests + docs, maybe it's worth investing time into testing & reviewing that one instead?

@catsby
Copy link
Contributor

catsby commented May 12, 2015

@radeksimko I poked @johnewart to submit this, he had mentioned he had it started.
#1888 has unknown repository as a source, which if I recall means the author pulled the branch down(?). The commits are still available, it seems...

I imagine we can likely combine the two, or just use #1888. I'd like to hear back from @mzupan on his branch.

@radeksimko
Copy link
Member

@catsby you're right... @mzupan apparently created the PR from master of his fork and then force-pushed over it... 😢

@pmoust
Copy link
Contributor

pmoust commented May 13, 2015

@radeksimko @catsby sorry just read you were discussing this, here is how to get a branch over a PRs head on GH @ #1888 (comment)

@johnewart
Copy link
Contributor Author

I see it now -- they're quite similar and that one already has tests so I'm fine with whichever makes more sense (or a combination of the two). I'll see if there's anything drastically different, but it didn't look like there was at fist glance.

@catsby
Copy link
Contributor

catsby commented May 15, 2015

LGTM, thanks!

catsby added a commit that referenced this pull request May 15, 2015
@catsby catsby merged commit 9f52192 into hashicorp:master May 15, 2015
@ghost
Copy link

ghost commented May 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants