command/format: Fix rendering of attribute-agnostic diagnostics

[radeksimko]

Depends on hashicorp/hcl2#58

Before

After

---

I'm thinking maybe we should suppress the "context string" to avoid the duplication, i.e.

  on /var/workspace/tf-test/repro-case/main.tf line 21:
  21: resource "aws_instance" "web" {

but then we might need the context in the future, more complex cases when we figure out how to render snippets with interpolated count.index? I'm not sure.

---

It is worth mentioning that there is currently no context rendered for errors returned during refresh or import, because the relevant EvalNode implementations (e.g. EvalRefresh) don't have access to config at all, so there is no way to match it at this point.

If we want to avoid passing config to these EvalNodes we might need to consider adding context in the form of IDs or something like that. 🤔

With all that said this is a problem to be solved in a future PR.

[apparentlymart]

LGTM, thanks!

w.r.t. the errors during state-only operations like refresh, indeed even if we did pass configuration in there we can't be sure it'd always be present since we perform refresh/destroy calls on objects that are no longer in the configuration. I do think there'll need to be some further iteration on this later, but what you've done here at least demonstrates that the part of the problem that lives within the SDK (and thus the provider binaries) is now working as expected and so we can work on further annotating the diagnostics in later Terraform Core releases without any protocol changes or forced provider upgrades.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.