Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump protocol version to 5 #20030

Merged
merged 2 commits into from
Jan 17, 2019
Merged

Bump protocol version to 5 #20030

merged 2 commits into from
Jan 17, 2019

Conversation

findkim
Copy link
Contributor

@findkim findkim commented Jan 16, 2019

Provider installer has been relying on the server protocol to resolve plugin protocol compatibility during discovery, which was protocol 4. This PR updates the installer to filter on protocol 5 instead

  • Separates TF client protocol from referencing server protocol
  • Bumps TF client protocol to 5
  • Keeps default server protocol to 4
  • Bumps terraform-bundle protocol to 5 for plugin discovery

Note: to target bundling an older terraform version, use the terraform-bundle of the same release or tag

@findkim findkim requested a review from a team January 16, 2019 19:04
Copy link
Contributor

@apparentlymart apparentlymart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Just one minor niggle inline, but the approach here seems good to me.

plugin/serve.go Outdated Show resolved Hide resolved
plugin/serve.go Outdated Show resolved Hide resolved
@findkim findkim merged commit ba6e243 into hashicorp:master Jan 17, 2019
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants