Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding rds snapshots #2062

Merged
merged 4 commits into from
Jul 2, 2015
Merged

Conversation

adamenger
Copy link
Contributor

Adding support for the ability to create an RDS instance from a previously saved DB snapshot. This pr adds the config option(snapshot_identifier) to the aws_db_instance resource and the conditional logic for handling this type of use case.

resource "aws_db_instance" "default" {
  identifier = "loadtest-rds-123"
  snapshot_identifier = "rds:production-2015-05-24-06-04"
  availability_zone = "us-east-1a"
  allocated_storage = 90
  engine = "postgres"
  engine_version = "9.3"
  instance_class = "db.m3.large"
  name = "mydb"
  username = "foo"
  password = "asdfasdfasdf"
  db_subnet_group_name = "staging-rds"
  parameter_group_name = "default.postgres9.3"
  apply_immediately = true
}

@catsby
Copy link
Contributor

catsby commented Jun 26, 2015

Can you merge/rebase from master, and add the new attributes to the documentation? Otherwise this looks good to me!

Thanks!

@catsby catsby added the waiting-response An issue/pull request is waiting for a response from the community label Jun 26, 2015
…g-rds-snapshots

* 'master' of github.com:reverbdotcom/terraform: (524 commits)
  docs: tweaks to RELEASING
  Minor change to docs
  Update CHANGELOG.md
  Update DynamoDB example docs to remove non-key attributes; update test to remove non-key attribute from attribute set to prevent infinite planning loops
  Update CHANGELOG.md
  use /usr/bin/env bash
  provider/aws: fix go vet
  provider/aws: ignore providers with Meta nil
  update CHANGELOG
  provider/aws: Code cleanups for Spot Requests
  provider/aws: fix db_subnet acc test
  Fixing the tests
  Fixes issue hashicorp#2568
  Update CHANGELOG.md
  Update CHANGELOG.md
  fixes typo
  Fixed void Azure network config bug.
  provider/aws: ecs task definition is deregistered correctly
  provider/azure: fixup storage service test
  provider/docker: [tests] change images
  ...
@adamenger
Copy link
Contributor Author

@catsby ok pushed! Looking forward to being able to use this in master. Cheers.

@catsby
Copy link
Contributor

catsby commented Jul 2, 2015

Everything checks out, I can still make dbs, dbs, with replicas, and now restore from a snapshot, thanks!

catsby added a commit that referenced this pull request Jul 2, 2015
@catsby catsby merged commit 460d49f into hashicorp:master Jul 2, 2015
@ghost
Copy link

ghost commented May 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement provider/aws waiting-response An issue/pull request is waiting for a response from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants