DynamoDB Support #2121
DynamoDB Support #2121
Conversation
|
Thanks @johnewart! I updated your comment with a fancy checklist to keep everyone up to speed on our progress here. Anything I can work on? |
|
Hmm, looks like I'll need to clean up this patch after I finish docs today. |
| }) | ||
| } | ||
|
|
||
| req.AttributeDefinitions = newAttributes |
There was a problem hiding this comment.
There's no call to dynamodbconn.UpdateTable(req) with this locally scoped req, or am I missing that? The update test doesn't check any changes in the attribute map so I think this snuck through.
Alternatively, is it worth building up a single UpdateTableInput struct for a single UpdateTable call?
|
One question, other than that 👍 |
|
Updated. |
|
Excellent work @johnewart, thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Opening because @catsby asked that I open a PR to let folks know I'm working on this and in case anyone has some feedback. Under 🚧 - I'll be writing tests and docs as well as finishing off a few things but it is mostly functional at this point.
Remaining: