Set AWS Elasticache Port Number to be required #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set Elasticache Port number to not be set by default, and require Elasticache Port number to be specified. Also updated acceptance tests to supply port number upon resource declaration Fixes hashicorp#2084
|
Thanks @grubernaut – can yo update https://github.com/hashicorp/terraform/blob/master/website/source/docs/providers/aws/r/elasticache_cluster.html.markdown as well, maybe even mentioning what the default is for Redis/Memcached? |
| @@ -123,7 +122,7 @@ func resourceAwsElasticacheClusterCreate(d *schema.ResourceData, meta interface{ | |||
| numNodes := int64(d.Get("num_cache_nodes").(int)) // 2 | |||
| engine := d.Get("engine").(string) // memcached | |||
| engineVersion := d.Get("engine_version").(string) // 1.4.14 | |||
| port := int64(d.Get("port").(int)) // 11211 | |||
| port := int64(d.Get("port").(int)) // e.g) 11211 | |||
There was a problem hiding this comment.
Should I remove the space after the parens?
|
@catsby Updated Documentation as requested |
|
LGTM! |
mitchellh
added a commit
that referenced
this pull request
Jun 8, 2015
provider/aws: Set AWS Elasticache Port Number to be required
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set Elasticache Port number to not be set by default, and require
Elasticache Port number to be specified.
Also updated acceptance tests to supply port number upon resource
declaration
Fixes #2084