provider/aws: Remove roles from profiles when trying to delete #2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
* master: (91 commits) update CHANGELOG update CHANGELOG state/remote: more canonical Go for skip TLS verify update CHANGELOG update CHANGELOG command/apply: flatten multierrors provider/aws: improve iam_policy err msgs acc tests: ensure each resource has a _basic test aws/provider convert _normal tests to _basic go fmt Enpoint type configuration for OpenStack provider Fix page title for aws_elasticache_cluster Update CHANGELOG.md Corrected Frankfurt S3 Website Endpoint fixes #2258 Only run Swift tests when Swift is available Implement OpenStack/Swift remote Minor correction to aws_s3_bucket docs docs: Fix wrong title (aws_autoscaling_notification) provider/aws: clarify scaling timeout error Update CHANGELOG.md ...
|
@mitchellh any thoughts on the |
|
I think in this case, since it's absolutely required that the role be detached from everything for it to be removed, that it's good as the default behavior. |
catsby
added a commit
that referenced
this pull request
Jun 8, 2015
provider/aws: Remove roles from profiles when trying to delete
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2049.
Summary:
nameof a IAM Role (at least at this time, via the API)Summoning @phinze and @mitchellh: this feels to me like a thing that should be behind a
force_detachtype flag, agree? As is, it removes the role from all profiles that it's attached to (I assume it's a many to many), not just any that's in the TF file(s)