Add additional protocols for ACL's and Security Groups

[mikeyhill]

ESP and AH cause an error.

* Invalid Protocol ESP for rule map[string]interface {}{"icmp_type":0, "icmp_code":0, "from_port":0, "to_port":65535, "rule_no":810, "action":"allow", "protocol":"ESP", "cidr_block":"0.0.0.0/0"}

I checked out the code and am not sure where the protocol numbers (https://www.iana.org/assignments/protocol-numbers/protocol-numbers.xhtml) are coming from so couldn't update it.

[phinze]

Hi @mikeyhill - looks like we have a mapping here if you wanted to take a stab at adding the ones you need:

terraform/builtin/providers/aws/network_acl_entry.go

Lines 72 to 81 in aed4462

	func protocolIntegers() map[string]int {
	var protocolIntegers = make(map[string]int)
	protocolIntegers = map[string]int{
	"udp": 17,
	"tcp": 6,
	"icmp": 1,
	"all": -1,
	}
	return protocolIntegers
	}

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.