provider/template: don't error when rendering fails in Exists #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phinze
force-pushed
the
b-template-variable-change-failure
branch
from
f4e2f32
to
62a6cca
Compare
| @@ -87,6 +94,8 @@ func Read(d *schema.ResourceData, meta interface{}) error { | |||
| return nil | |||
| } | |||
|
|
|||
| type TemplateRenderError error | |||
There was a problem hiding this comment.
Don't think this needs to be exported, since we only return it from a private function?
There was a problem hiding this comment.
Good call. I was just so excited that this was my first time using error types in Go that I wanted the whole world to see my error type! 😁
|
Nitpick, but LGTM |
The Exists function can run in a context where the contents of the template have changed, but it uses the old set of variables from the state. This means that when the set of variables changes, rendering will fail in Exists. This was returning an error, but really it just needs to be treated as a scenario where the template needs re-rendering. fixes #2344 and possibly a few other template issues floating around
phinze
force-pushed
the
b-template-variable-change-failure
branch
from
62a6cca
to
385b17d
Compare
phinze
added a commit
that referenced
this pull request
Jun 17, 2015
…ilure provider/template: don't error when rendering fails in Exists
This was referenced Jun 17, 2015
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Exists function can run in a context where the contents of the
template have changed, but it uses the old set of variables from the
state. This means that when the set of variables changes, rendering will
fail in Exists. This was returning an error, but really it just needs to
be treated as a scenario where the template needs re-rendering.
fixes #2344 and possibly a few other template issues floating around