Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add aws_launch_configuration.enable_monitoring #2410

Merged
merged 1 commit into from
Jun 25, 2015

Conversation

radeksimko
Copy link
Member

Closes #479

I'm not convinced we should make this disabled by default. We had a similar situation in the past - when changing behaviour of egress rules in security groups where the default egress rule allowing all traffic was suddenly removed by default (and kept in the previous TF versions). This was BC, but it reality worst case scenario was that instances couldn't talk to the outside world -> de facto no direct data loss.

I don't think that disabling detailed monitoring suddenly is a good idea for people who rely on those data.

Nonetheless if anyone comes up with a meaningful reason why we should do the BC, I'm open.

Test plan

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSLaunchConfiguration' 2>/dev/null
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=AWSLaunchConfiguration -timeout 90m
=== RUN TestAccAWSLaunchConfiguration_basic
--- PASS: TestAccAWSLaunchConfiguration_basic (2.60s)
=== RUN TestAccAWSLaunchConfiguration_withBlockDevices
--- PASS: TestAccAWSLaunchConfiguration_withBlockDevices (3.98s)
=== RUN TestAccAWSLaunchConfiguration_withSpotPrice
--- PASS: TestAccAWSLaunchConfiguration_withSpotPrice (1.92s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    8.516s

cc @bantonj @frntn

@mitchellh
Copy link
Contributor

LGTM, merge at will.

radeksimko added a commit that referenced this pull request Jun 25, 2015
provider/aws: Add aws_launch_configuration.enable_monitoring
@radeksimko radeksimko merged commit dc26f06 into hashicorp:master Jun 25, 2015
@radeksimko radeksimko deleted the f-aws-lc-monitoring branch June 25, 2015 06:02
@ghost
Copy link

ghost commented May 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_launch_configuration > monitoring argument missing
2 participants