provider/aws: Add aws_launch_configuration.enable_monitoring #2410
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #479
I'm not convinced we should make this disabled by default. We had a similar situation in the past - when changing behaviour of
egress
rules in security groups where the default egress rule allowing all traffic was suddenly removed by default (and kept in the previous TF versions). This was BC, but it reality worst case scenario was that instances couldn't talk to the outside world -> de facto no direct data loss.I don't think that disabling detailed monitoring suddenly is a good idea for people who rely on those data.
Nonetheless if anyone comes up with a meaningful reason why we should do the BC, I'm open.
Test plan
cc @bantonj @frntn