Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry to aws_launch_configuration Create to wait for IAM instance profile propagation #2452

Conversation

zollie
Copy link

@zollie zollie commented Jun 24, 2015

Wrapped aws_launch_configuration Create in a resource.Retry to wait for IAM instance profile propagation.

This should fix Issue: #2349

@zollie
Copy link
Author

zollie commented Jun 24, 2015

#2349 seems a duplicate of #2136 as well

@zollie zollie changed the title Wrapped Create in a resource.Retry to wait for IAM instance profile p… Add retry to create launch config to wait for IAM instance profile propagation Jun 24, 2015
@zollie zollie changed the title Add retry to create launch config to wait for IAM instance profile propagation Add retry aws_launch_configuration Create to wait for IAM instance profile propagation Jun 24, 2015
@zollie zollie changed the title Add retry aws_launch_configuration Create to wait for IAM instance profile propagation Add retry to aws_launch_configuration Create to wait for IAM instance profile propagation Jun 24, 2015
@catsby
Copy link
Contributor

catsby commented Jun 24, 2015

Hey @zollie thanks for the patch!
What is the error code or message when this happens? Can we retry on just that error? As it stands, this would retry for 30 seconds in the face of any error, not just IAM propagation ones

@phinze
Copy link
Contributor

phinze commented Jun 24, 2015

Hi @zollie - check out my comment over on #2349 for the approach I think we should take to handle this.

@zollie
Copy link
Author

zollie commented Jun 24, 2015

@catsby yes, the more specific the better. Please see last PR.

@mitchellh
Copy link
Contributor

This LGTM.

mitchellh added a commit that referenced this pull request Jun 25, 2015
…le-propagation-wait

provider/aws: Add retry to aws_launch_configuration Create to wait for IAM instance profile propagation
@mitchellh mitchellh merged commit a4070a1 into hashicorp:master Jun 25, 2015
@zollie zollie deleted the f-aws-launch-configuration-profile-propagation-wait branch June 25, 2015 13:59
@ilijaljubicic
Copy link

seems I have same issue with aws_cloudwatch_log_group resource.
later I use {aws_cloudwatch_log_group.logs.arn} inside template_file to create template
with arn of log group and it fails (says no arn) and on second run it goes through.

trick I used for IAM (local exec of 30 sec) seems not to work even when increased to 60secs.

@phinze
Copy link
Contributor

phinze commented Dec 2, 2015

Hi there, can you open a fresh issue so we can track the need for this on aws_cloudwatch_log_group separately? Thanks!

@ghost
Copy link

ghost commented Apr 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants