terraform: orphan dependencies should be inverted #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| t.Fatalf("bad: %s", actual) | ||
| } | ||
| } | ||
|
|
||
| /* | ||
| TODO: This exposes a really bad bug we need to fix after we merge | ||
| the f-ast-branch. This bug still exists in master. |
There was a problem hiding this comment.
This comment looks ominous. 😐
There was a problem hiding this comment.
Hah, we've talked about this before. It has been commented since that marge... hasn't caused problems yet... but we keep it around to figure out what it is.
|
LGTM! |
mitchellh
added a commit
that referenced
this pull request
Jun 24, 2015
terraform: orphan dependencies should be inverted
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2363
This is a weird-ish one. I'm not sure when this regression happened actually but it feels... old. Like, I think this might be back from the original graph refactor...
Anyways, when an orphan depends on another orphan, the dependencies should be inverted. We do this all within the framework of the existing
DestroyTransformerbut having the nodes implementGraphNodeDestroyable.The only weird thing is we had to add an edge case handler for if the destroy node equals the creation node (in
transform_destroy.go). I've commented this to note what is going on.