provider/aws: Allow in-place updates for ElastiCache cluster #2469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -60,6 +60,10 @@ names to associate with this cache cluster | |||
| * `security_group_ids` – (Optional, VPC only) One or more VPC security groups associated | |||
| with the cache cluster | |||
|
|
|||
| * `apply_immediately` - (Optional) Specifies whether any database modifications | |||
| are applied immediately, or during the next maintenance window. Default is | |||
| `false`. See [Amazon ElastiCache Documentation for more information.][1] | |||
There was a problem hiding this comment.
Can we add a (available since v0.6.0) in here. I'm not sure where.... maybe just at the end.
|
One comment. LGTM. |
|
@phinze added cluster status polling in 76291b7 , updating a security group typically takes 1 cycle (~5 seconds), and adding nodes takes a few minutes for the node to be up and report "available" |
|
LGTM |
catsby
force-pushed
the
f-aws-update-elasticache
branch
from
76291b7 to
2e23210
Compare
catsby
added a commit
that referenced
this pull request
Jun 25, 2015
provider/aws: Allow in-place updates for ElastiCache cluster
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2303 but improving the
updatemethod in the ElastiCache resource.You can now update the following without recreating the resource:
engineengine_versionnum_cache_nodes(for memcached)parameter_group_namesecurity_group_ids