Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building of EC2 instances with ebs_optimized flag #260

Merged
merged 1 commit into from
Sep 7, 2014

Conversation

jkinred
Copy link
Contributor

@jkinred jkinred commented Sep 3, 2014

Allows building of instances that are EBS optimized.

Depends on pull request in mitchellh/goamz:
mitchellh/goamz#94

I didn't write any tests because this is my first Go code and although I had a go at working out how the tests were supposed to be written, it wasn't clear to me. Happy to write a test with some guidance!

I did a manual test and the flag was set on the instance and is shown in the .tfstate file:

jonathan@nomad $ ./bin/terraform show terraform.tfstate 
aws_instance.example:
  id = i-cc722af2
  ami = ami-7798074d
  availability_zone = ap-southeast-2b
  ebs_optimized = true
  instance_type = c3.xlarge
  key_name = 
  private_dns = ip-172-31-7-7.ap-southeast-2.compute.internal
  private_ip = 172.31.7.7
  public_dns = ec2-54-206-73-128.ap-southeast-2.compute.amazonaws.com
  public_ip = 54.206.73.128
  security_groups.# = 1
  security_groups.0 = default
  subnet_id = subnet-713d3413

@mitchellh
Copy link
Contributor

This looks good! Thanks.

mitchellh added a commit that referenced this pull request Sep 7, 2014
providers/amazon: Allow building of EC2 instances with ebs_optimized flag
@mitchellh mitchellh merged commit 634dd7e into hashicorp:master Sep 7, 2014
mitchellh added a commit that referenced this pull request Sep 7, 2014
@ghost ghost locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants