Allow dots in the name of aws_db_subnet_group

[bitglue]

The RDS API reference doesn't say dots are allowed, but they are. For
the sake of people who have preexisting resources with dots in the
names, we should allow them also. Fixes #2664.

[radeksimko]

@bitglue Thanks for the report and PR!

Like AWS, we allow it but don't say it.

I'm not entirely convinced that's a good approach.

Would you mind updating the error message (i.e. mentioning dots are allowed too) instead of adding the comment & add a test similar to 0ba0419 , please?

[bitglue]

Well, attempted to add a test, but either both I and Travis don't understand how to run it, or it's not actually testing anything useful, since the tests pass even if I totally break the regex.

[phinze]

Hi @bitglue - it's an acceptance test that interacts with an AWS account, so it won't be run by travis. The README has details on how to run acc tests.

[bitglue]

OK well, I put it back to a working configuration. I don't know if the tests work or not -- running the acceptance tests is beyond the threshold of effort I can expend on a one-character bugfix.

[phinze]

Sounds good @bitglue, we can double check them on our side.

[radeksimko]

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=DBSubnetGroup' 2>/dev/null

go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=DBSubnetGroup -timeout 90m
=== RUN TestAccAWSDBSubnetGroup_basic
--- PASS: TestAccAWSDBSubnetGroup_basic (15.76s)
=== RUN TestAccAWSDBSubnetGroup_withUnderscores
--- PASS: TestAccAWSDBSubnetGroup_withUnderscores (12.57s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    28.348s

^ works aok => 👍 @bitglue

the test could be renamed too, but I can do it afterwards.

[radeksimko]

FYI I just reported this to AWS as I did underscores a while back too.
It has been acknowledged and docs will get updated.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.