Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/aws: Improved Auto Scaling Groups updates #2724

Merged
merged 3 commits into from
Jul 15, 2015
Merged

provider/aws: Improved Auto Scaling Groups updates #2724

merged 3 commits into from
Jul 15, 2015

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Jul 14, 2015

  • availability zones are optional if you specify a VPC Zone Identifier (subnet)
  • availability zones can be updated in place

Fixes #2338

Remaining:

  • doc update

@catsby
provider/aws: Improved Auto Scaling Groups updates
ed98e02 
- availability zones are optional if you specify a VPC Zone Identifier (subnet)
- availability zones can be updated in place
@catsby catsby mentioned this pull request Jul 14, 2015
Closed
@phinze
Copy link
Contributor

phinze commented Jul 14, 2015

So we're giving up the plan-time validation in the Classic deploy case, but I think that's AOK. I'm always willing to take from Classic UX if it means improving VPC UX.

@phinze
Copy link
Contributor

phinze commented Jul 14, 2015

(LGTM so far, will give it one more review after docs land.)

@catsby
Copy link
Contributor Author

catsby commented Jul 14, 2015

So we're giving up the plan-time validation in the Classic deploy case,

Unfortunately yes, until we have a RequiredUnless concept in the Schema

@catsby
Copy link
Contributor Author

catsby commented Jul 14, 2015

@phinze doc update in 55a1a31 just mentions that AZ is optional if VPC Zone is not specified

catsby added a commit that referenced this pull request Jul 15, 2015
@catsby
Merge pull request #2724 from hashicorp/f-aws-asg-updates
abe62e6 
provider/aws: Improved Auto Scaling Groups updates
@catsby catsby merged commit abe62e6 into master Jul 15, 2015
@catsby catsby deleted the f-aws-asg-updates branch July 15, 2015 13:42
@ghost
Copy link

ghost commented May 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug provider/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_autoscaling_group should not require availability_zones when vpc_zone_identifier is provided
3 participants
@catsby @phinze @radeksimko