Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Fix issue with Launch Configurations and enable_monitoring #2735

Merged
merged 1 commit into from
Jul 15, 2015

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Jul 15, 2015

Previously, because of how d.GetOk works, this block was never being executed and you could not set this value to false. By adding a default of true to match AWS, we can determine if the value is false and set it correctly.

Fixes #2734

@cbednarski
Copy link
Contributor

LGTM!

catsby added a commit that referenced this pull request Jul 15, 2015
provider/aws: Fix issue with Launch Configurations and enable_monitoring
@catsby catsby merged commit f0bed18 into master Jul 15, 2015
@catsby catsby deleted the b-aws-lc-enable-monitoring-fix branch July 15, 2015 22:02
@ghost
Copy link

ghost commented May 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS LaunchConfig Enable_monitoring
2 participants