Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This adds the source_dest_check attribute to the aws_network_interfac… #2741

Merged
merged 1 commit into from
Jul 23, 2015

Conversation

jszwedko
Copy link
Contributor

…e resource

Addresses #2407

@stack72
Copy link
Contributor

stack72 commented Jul 16, 2015

This is the same as #2721 but I am happy to close mine as you have added tests :)

@stack72
Copy link
Contributor

stack72 commented Jul 20, 2015

@catsby / @phinze / @radeksimko any chance someone could have a look at this - it's a blocker for running a better HA solution for NAT boxes (using ENI and EIPs)

thanks :)

@stack72
Copy link
Contributor

stack72 commented Jul 22, 2015

bump

"source_dest_check": &schema.Schema{
Type: schema.TypeBool,
Optional: true,
Computed: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add Default: true, here, or otherwise any user who omits the source_dest_check attribute will send a false value to the API

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which also means that we need to remove the Computed part here (can't have both computed and default)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Missed that when I removed the guarding conditional.

@catsby
Copy link
Contributor

catsby commented Jul 22, 2015

A few nitpicks but overall looks good! Let's see about the updates and making sure all the Acceptance tests pass, then we'll be good 👍

@catsby catsby added the waiting-response An issue/pull request is waiting for a response from the community label Jul 22, 2015
…e resource

Defaults to true to be consistent with AWS
@jszwedko
Copy link
Contributor Author

@catsby swapped Computed for Default and made sure all of the acceptance tests for AWS ENI pass. Also squashed it down to keep the commit history cleaner.

Let me know if any more changes need to be made, thanks for looking at this!

@catsby
Copy link
Contributor

catsby commented Jul 23, 2015

Looking great now, thanks! Pulling this in

catsby added a commit that referenced this pull request Jul 23, 2015
This adds the source_dest_check attribute to the aws_network_interfac…
@catsby catsby merged commit d78dc74 into hashicorp:master Jul 23, 2015
@jszwedko
Copy link
Contributor Author

Awesome, thanks! 🎺

@ghost
Copy link

ghost commented May 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement provider/aws waiting-response An issue/pull request is waiting for a response from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants