Grandchild module orphans should be destroyed #2786
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2770
This was an interesting bug found by @ryanking. Basically: when adding orphan modules to the graph, only direct descendants were added by inspecting the state. If the direct descendant has no state (no resources in the original config), then grandchildren will never get discovered and never added to the graph.
This PR mainly modifies
State.ModuleOrphans
to return orphans that have grandchildren even if they're not in the state.This PR also contains a few bug fixes necessary to make this work otherwise, but the above is the meat of the change.
(Aside: we should really switch to a tree structure internally to make functions like ModuleOrphans more efficient than
O(N)
, but... one day).