provider/openstack: add state 'downloading' to resource 'blockstorage_volume_v1'

[berendt]

When using an image as the source of new volume the state 'downloading'
prior to the state 'available' is fine.

It is also fine to destroy a volume in the state 'downloading'.

Closes-bug: #2865

[jtopjian]

@berendt Nice catch. 😄

Can you add a test for this? I think this is definitely something that should be checked for regression in the future.

I have a gist here that sets up a devstack environment from within OpenStack using Terraform to run the test suite.

Also, did you mean "Closes-bug: #2865"? 😄

[berendt]

@jtopjian Updated the commit message. I am not familiar with Go and I do not know how to write good tests for the test suite. Can you take care of it in a second PR? At least post some some URLs where I can get more details about how to write tests for Go.

[jtopjian]

@berendt No worries.

In general, the *_test.go files under the OpenStack Provider directory are where the tests go. The Terraform README has instructions on how to run them. The gist I linked to bundles everything up in one shot.

I've just submitted a PR to your fork that includes a test. 😄

[berendt]

@jtopjian Thanks. I will have a look and next time I can provide my own test.

[jtopjian]

@berendt It's really no problem. Terraform doesn't require tests for fixes and such. With this particular patch, I wanted to see a test since it's a core feature of the provider, so I had no issues at all writing it myself :)

[berendt]

@jtopjian Merged your PR and rebased it. This PR should be fine now.

[jtopjian]

@berendt: Nice 👍

@phinze: Can you do a quick review when you get a chance?

[phinze]

LGTM - thanks everybody!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.