Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gce autoscaling #2868

Merged
merged 12 commits into from
Jul 28, 2015
Merged

Gce autoscaling #2868

merged 12 commits into from
Jul 28, 2015

Conversation

sparkprime
Copy link
Contributor

Original work by @dwatson
Updated and tested anew by me, and resources renamed to reflect their belonging to the compute API now.

I tried to remove the merge commits but git started giving me strange merge conflicts... so I chickened out. It's definitely good to keep the original work from earlier this year.

David Watson and others added 10 commits February 16, 2015 16:06
Additionally:
Update CHANGELOG
Make cooldown period optional for autoscaler
Refactor autoscaler and add more error checking
Instance template now supports image aliases
Replace instance group manager 'size' -- use target_size (now writeable)
Add documentation for autoscaler
Add beta warnings to docs
@sparkprime
Copy link
Contributor Author

Actually the instance group manager "basic" test is a bit flakey, and when it fails it breaks the "update" one from running because of a dangling resource. I will make the tests more robust and then follow up why the basic test is flakey.

@sparkprime
Copy link
Contributor Author

It was only flakey because it takes longer now. Updating the timeout seems to have fixed it.

The reason it takes longer in GA is that the insert operation has changed to be more asynchronous. Insert will complete before instances have finished being created. But if you immediately delete the instance group manager after creating it (as in the acceptance tests), the delete first waits for the instances to be created before deleting them.

sparkprime added a commit that referenced this pull request Jul 28, 2015
@sparkprime sparkprime merged commit 4fa6871 into hashicorp:master Jul 28, 2015
@ghost
Copy link

ghost commented May 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants