-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gce autoscaling #2868
Gce autoscaling #2868
Conversation
Additionally: Update CHANGELOG Make cooldown period optional for autoscaler Refactor autoscaler and add more error checking Instance template now supports image aliases Replace instance group manager 'size' -- use target_size (now writeable) Add documentation for autoscaler Add beta warnings to docs
Actually the instance group manager "basic" test is a bit flakey, and when it fails it breaks the "update" one from running because of a dangling resource. I will make the tests more robust and then follow up why the basic test is flakey. |
It was only flakey because it takes longer now. Updating the timeout seems to have fixed it. The reason it takes longer in GA is that the insert operation has changed to be more asynchronous. Insert will complete before instances have finished being created. But if you immediately delete the instance group manager after creating it (as in the acceptance tests), the delete first waits for the instances to be created before deleting them. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Original work by @dwatson
Updated and tested anew by me, and resources renamed to reflect their belonging to the compute API now.
I tried to remove the merge commits but git started giving me strange merge conflicts... so I chickened out. It's definitely good to keep the original work from earlier this year.