provider/aws: Paginate the notifications returned for ASG Notifications

[catsby]

Update AutoScaling Group Notifications to page through results of DescribeNotificationConfigurations. There is a result for each Notification Type : Group pair, so the list can be long if you have a lot, like so:

resource "aws_autoscaling_group" "bar" {
  count = 20
  name = "foobar3-terraform-test-${count.index}"
  [...]
}

resource "aws_autoscaling_notification" "example" {
  group_names = [
    "${aws_autoscaling_group.bar.*.name}",
  ]
  notifications  = [
    "autoscaling:EC2_INSTANCE_LAUNCH",
    "autoscaling:EC2_INSTANCE_TERMINATE",
    "autoscaling:TEST_NOTIFICATION"
  ]
    topic_arn = "${aws_sns_topic.user_updates.arn}"
}

That will generate 60 results in the DescribeNotificationConfigurations call, but it's paginated unless you specify the max records. Max records is limited to 200, so it's better to just paginate since it's provided for us.

Fixes #2852

[stack72]

@catsby works well - just tested this!

Thanks :)

[stack72]

@catsby any way this can be merged? Every terraform apply shows me ASG changes :) So it panics the devs haha

[stack72]

@catsby thanks for merging this - this has solved my continual changes issue :)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.