Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cidrnetmask() produce an error with IPv6 #30703

Merged
merged 3 commits into from
Mar 25, 2022
Merged

cidrnetmask() produce an error with IPv6 #30703

merged 3 commits into from
Mar 25, 2022

Conversation

shinbunbun
Copy link
Contributor

Make cidrnetmask() produce an error when trying to create a netmask for IPv6.

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 19, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@shinbunbun
Copy link
Contributor Author

@laurapacilio @kmoe

Hi, I have tried to solve this Issue.
If you don't mind, could you please review it?

@crw crw added the bug label Mar 21, 2022
@crw
Copy link
Contributor

crw commented Mar 21, 2022

Thanks for the submission!

kmoe
kmoe approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@kmoe kmoe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Looks good. Error message could have a bit more context - see comment.

@shinbunbun @kmoe
Update internal/lang/funcs/cidr.go
fa24bd6 
Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com>
@shinbunbun shinbunbun marked this pull request as ready for review March 24, 2022 15:28
@shinbunbun
Copy link
Contributor Author

@kmoe
Thank you for your review!
I accepted your suggestion.

@mtslzr mtslzr mentioned this pull request Mar 24, 2022
Closed
@kmoe kmoe merged commit a1ead44 into hashicorp:main Mar 25, 2022
@github-actions
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kmoe kmoe kmoe approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cidrnetmask() should error with IPv6
4 participants
@shinbunbun @hashicorp-cla @crw @kmoe