-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backend/azurerm: exclusively using Microsoft Graph/MSAL and removing Azure Active Directory Graph/ADAL #31070
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
I don't have sufficient context to comment on the code changes here but just wanted to be explicit that you can merge this when ready since the main branch is already tracking what will become Terraform v1.3, and so we'll only be cutting v1.3 prereleases from this branch until we reach v1.3.0 final. (1.2 releases come from the v1.2 branch.) |
Thanks @apparentlymart, this is ready to go so merging now. |
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR finishes the migration from ADAL to MSAL for the AzureRM Backend - meaning that Microsoft Graph (and MSAL) are now used by default and Azure Active Directory Graph (and ADAL) are no longer available.
Whilst this is technically a breaking change to the config, this has been called out in the v1.1 and v1.2 releases (and is marked as deprecated in v1.2) - we believe that this shouldn't be impactful to users - and ADAL is scheduled for removal in the near future: https://docs.microsoft.com/graph/migrate-azure-ad-graph-faq