-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http-backend: http backend lock error return LockError instead of generic error #31256
Conversation
6eb9898
to
c487be6
Compare
c487be6
to
bb1c134
Compare
mentioned here as well #27670 (comment) |
Thanks for this submission! I cannot commit to having this PR reviewed due to the general hold on backend reviews (see CONTRIBUTING.md#state-storage-backends. That said, I will bring this up in triage and see if this can be reviewed. Thanks again for your submission! |
@crw Hey Craig, thanks for the reply, really appreciate it! FYI, this is more of a bug fix than an enhancement if that changes anything for the review process. In any case, thank you for your time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix! If you know of a related GitHub issue, please let me know so I can close it.
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
@alisdair Hey! Thank you for merging! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR make the http backend respect the lock-timeout flag. Currently, there is no way to wait for a lock when using http backend.
With this PR :